Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2611)

Unified Diff: chrome/browser/chromeos/policy/user_network_configuration_updater.cc

Issue 325313004: Cleanup tests using SetSkipCertificateImporterCreationForTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_network_configuration_updater.cc
diff --git a/chrome/browser/chromeos/policy/user_network_configuration_updater.cc b/chrome/browser/chromeos/policy/user_network_configuration_updater.cc
index c1af009a2d184a22d4cce22f48691fe8c5358f82..27173fe13676ad66306be5c3064e09b226839798 100644
--- a/chrome/browser/chromeos/policy/user_network_configuration_updater.cc
+++ b/chrome/browser/chromeos/policy/user_network_configuration_updater.cc
@@ -19,12 +19,6 @@
#include "net/cert/x509_certificate.h"
#include "policy/policy_constants.h"
-namespace {
-
-bool skip_certificate_importer_creation_for_test = false;
-
-} // namespace
-
namespace policy {
UserNetworkConfigurationUpdater::~UserNetworkConfigurationUpdater() {}
@@ -74,12 +68,10 @@ UserNetworkConfigurationUpdater::UserNetworkConfigurationUpdater(
// responsible for creating it. This requires |GetNSSCertDatabaseForProfile|
// call, which is not safe before the profile initialization is finalized.
// Thus, listen for PROFILE_ADDED notification, on which |cert_importer_|
- // creation should start. This behaviour can be disabled in tests.
- if (!skip_certificate_importer_creation_for_test) {
- registrar_.Add(this,
- chrome::NOTIFICATION_PROFILE_ADDED,
- content::Source<Profile>(profile));
- }
+ // creation should start.
+ registrar_.Add(this,
+ chrome::NOTIFICATION_PROFILE_ADDED,
+ content::Source<Profile>(profile));
}
void UserNetworkConfigurationUpdater::SetCertificateImporterForTest(
@@ -87,12 +79,6 @@ void UserNetworkConfigurationUpdater::SetCertificateImporterForTest(
SetCertificateImporter(certificate_importer.Pass());
}
-// static
-void UserNetworkConfigurationUpdater::
-SetSkipCertificateImporterCreationForTest(bool skip) {
- skip_certificate_importer_creation_for_test = skip;
-}
-
void UserNetworkConfigurationUpdater::GetWebTrustedCertificates(
net::CertificateList* certs) const {
*certs = web_trust_certs_;
@@ -135,9 +121,6 @@ void UserNetworkConfigurationUpdater::Observe(
DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_ADDED);
Profile* profile = content::Source<Profile>(source).ptr();
- if (skip_certificate_importer_creation_for_test)
- return;
-
GetNSSCertDatabaseForProfile(
profile,
base::Bind(

Powered by Google App Engine
This is Rietveld 408576698