Issue 325133004: Fix unsigned comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325133004: Fix unsigned comparisons. (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix unsigned comparisons. Instead of marking the comparison instruction itself as Uint32, we look at its arguments. This is more consistent what HChange does. BUG=v8:3380 TEST=mjsunit/regress/regress-3380 LOG=y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21762

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/hydrogen-uint32-analysis.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-3380.js	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

6 years, 6 months ago (2014-06-11 09:09:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21762 (presubmit successful).