src/hydrogen-uint32-analysis.cc - Issue 325133004: Fix unsigned comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-uint32-analysis.cc

Issue 325133004: Fix unsigned comparisons. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Assert, don't print... Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-uint32-analysis.cc

diff --git a/src/hydrogen-uint32-analysis.cc b/src/hydrogen-uint32-analysis.cc

index ce450a1de84701d00d21294f27b1d664e6b93363..7616f3d46b61a6416a6bc6917b4ed56158b76032 100644

--- a/src/hydrogen-uint32-analysis.cc

+++ b/src/hydrogen-uint32-analysis.cc

@@ -62,7 +62,6 @@ bool HUint32AnalysisPhase::IsSafeUint32Use(HValue* val, HValue* use) {

}

} else if (use->IsCompareNumericAndBranch()) {

- return false; // TODO(svenpanne/3380): Fix and re-enable!

HCompareNumericAndBranch* c = HCompareNumericAndBranch::cast(use);

return IsUint32Operation(c->left()) && IsUint32Operation(c->right());

}

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »