src/arm64/lithium-codegen-arm64.cc - Issue 325133004: Fix unsigned comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 325133004: Fix unsigned comparisons. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Assert, don't print... Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 1ac579f0f61affe622899924404f0725c5783308..f301c8b765853ccc204cd04361757f68ac65f6cd 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -2470,7 +2470,9 @@ void LCodeGen::DoCompareMinusZeroAndBranch(LCompareMinusZeroAndBranch* instr) {

void LCodeGen::DoCompareNumericAndBranch(LCompareNumericAndBranch* instr) {

LOperand* left = instr->left();

LOperand* right = instr->right();

- bool is_unsigned = instr->hydrogen()->CheckFlag(HInstruction::kUint32);

+ bool is_unsigned =

+ instr->hydrogen()->left()->CheckFlag(HInstruction::kUint32) ||

+ instr->hydrogen()->right()->CheckFlag(HInstruction::kUint32);

Condition cond = TokenToCondition(instr->op(), is_unsigned);

if (left->IsConstantOperand() && right->IsConstantOperand()) {

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-uint32-analysis.cc » ('j') | no next file with comments »