Refactor BufferData class into a separate file to be later used by individual gbm_bo's in EGLImage.

Refactor BufferData class into a separate file to be later used by individual gbm_bo's in EGLImage.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276554

[alexst (slow to review), 2014-06-11 03:27:56]

Starting to refactor GBM platform to allow for surfaceless compositor and
overlays.

[dnicoara, 2014-06-11 03:34:51]

lgtm

[rjkroege, 2014-06-11 14:43:04]

lgtm with nits.

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
File ui/ozone/platform/dri/buffer_data.cc (right):

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.cc:15: // TODO(dnicoara) These will need to
change once we'll query the hardware for
grammar nit: "once we query"

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.cc:61: void BufferData::Destroy(gbm_bo*
buffer, void* data) {
this is necessary because gbm is a C-style API and calls back into this class?
bd here is "this"?

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
File ui/ozone/platform/dri/buffer_data.h (right):

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.h:16: class BufferData {
What is this class for? Can you explain?

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.h:24: // Callback used by GBM to destory the
BufferData associated with a buffer.
nit destory

[alexst (slow to review), 2014-06-11 15:00:06]

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
File ui/ozone/platform/dri/buffer_data.cc (right):

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.cc:15: // TODO(dnicoara) These will need to
change once we'll query the hardware for
On 2014/06/11 14:43:04, rjkroege wrote:
> grammar nit: "once we query"

Done.

https://codereview.chromium.org/325133003/diff/1/ui/ozone/platform/dri/buffer...
ui/ozone/platform/dri/buffer_data.cc:61: void BufferData::Destroy(gbm_bo*
buffer, void* data) {
On 2014/06/11 14:43:04, rjkroege wrote:
> this is necessary because gbm is a C-style API and calls back into this class?
> bd here is "this"?
> 

yes

[alexst (slow to review), 2014-06-11 15:00:11]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-06-11 15:02:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/325133003/20001

[commit-bot: I haz the power, 2014-06-11 20:56:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:25:05]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[alexst (slow to review), 2014-06-11 21:58:35]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:00:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/325133003/20001

[commit-bot: I haz the power, 2014-06-11 22:28:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 22:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:32:31]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[alexst (slow to review), 2014-06-12 01:26:58]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-06-12 01:28:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/325133003/20001

[commit-bot: I haz the power, 2014-06-12 02:27:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-12 06:56:59]

Change committed as 276554