Delete RenderLayerCompositor::layerWillBeRemoved

Delete RenderLayerCompositor::layerWillBeRemoved

This function doesn't do anything. The repaint it generates is redundant and
marking the RenderLayerCompositor as needing a rebuild is redundant because
RenderLayerStackingNode will already mark the same dirty bit. It's more
sensible for RenderLayerStackingNode to be responsible for setting this dirty
bit because the reason it needs to be set is that the stacking tree has changed.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175941

[abarth-chromium, 2014-06-11 00:41:51]

Depends on https://codereview.chromium.org/326253002 but can be reviewed before
that CL lands.

[esprehn, 2014-06-11 00:48:48]

I don't trust this, the regular RenderObject repaint path doesn't understand
composited bounds, so removing the
child->compositedLayerMapping()->compositedBounds() makes me wonder what else is
making an invalidation, and how it could possibly know the right rect to use.
Once the layer is completely removed we lose all that state. Maybe the system
that tears down the GraphicsLayers is doing it?

lgtm, hopefully we'll catch any regression this causes quickly. :)

[chrishtr, 2014-06-11 01:19:23]

On 2014/06/11 at 00:48:48, esprehn wrote:
> I don't trust this, the regular RenderObject repaint path doesn't understand
composited bounds, so removing the
child->compositedLayerMapping()->compositedBounds() makes me wonder what else is
making an invalidation, and how it could possibly know the right rect to use.
Once the layer is completely removed we lose all that state. Maybe the system
that tears down the GraphicsLayers is doing it?
> 
> lgtm, hopefully we'll catch any regression this causes quickly. :)

In this case the child RenderLayer is being deleted, and the code only has any
effect if the child RenderLayer has a CLM. In that case, the graphics layer for
it will be deleted because the RenderLayer is going away, and will issue a
repaint if so for its bounds.

So I think this CL is correct w.r.t that aspect. (Didn't check the dirty bit
part.)

[abarth-chromium, 2014-06-11 01:28:56]

On 2014/06/11 at 01:19:23, chrishtr wrote:
> In this case the child RenderLayer is being deleted, and the code only has any
effect if the child RenderLayer has a CLM. In that case, the graphics layer for
it will be deleted because the RenderLayer is going away, and will issue a
repaint if so for its bounds.

Thanks!

> So I think this CL is correct w.r.t that aspect. (Didn't check the dirty bit
part.)

I'm confident in the dirty bit aspect.  That's easy to check by seeing that both
callers either call RenderLayerStackingNode::dirtyNormalFlowList or
RenderLayerStackingNode::dirtyZOrderLists.

[abarth-chromium, 2014-06-11 01:28:58]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:29:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/325063003/1

[commit-bot: I haz the power, 2014-06-11 01:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:29:34]

Failed to apply patch for
Source/core/rendering/compositing/RenderLayerCompositor.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/compositing/RenderLayerCompositor.h
  Hunk #1 FAILED at 123.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/compositing/RenderLayerCompositor.h.rej

Patch:       Source/core/rendering/compositing/RenderLayerCompositor.h
Index: Source/core/rendering/compositing/RenderLayerCompositor.h
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.h
b/Source/core/rendering/compositing/RenderLayerCompositor.h
index
c65b26247f9a013a9e26b9e09cfbd01ea3c0b048..f2e9b5442805d6f2e1d813201f9fa7e25252c2ca
100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.h
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.h
@@ -123,9 +123,6 @@ public:
     void repaintOnCompositingChange(RenderLayer*);
 
     void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&);
-
-    void layerWillBeRemoved(RenderLayer* parent, RenderLayer* child);
-
     void repaintCompositedLayers();
 
     RenderLayer* rootRenderLayer() const;

[abarth-chromium, 2014-06-11 03:42:13]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-11 03:42:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/325063003/1

[commit-bot: I haz the power, 2014-06-11 04:47:05]

Change committed as 175941