Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 326253002: Inline RenderLayerCompositor::layerWasAdded (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Inline RenderLayerCompositor::layerWasAdded This function ignores both its arguments and is one line. It's clearer if we just inline it and match it up with the call to setNeedsCompositingInputsUpdate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 00:25:27 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-11 00:26:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/326253002/1
6 years, 6 months ago (2014-06-11 00:27:03 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-11 01:39:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 01:39:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/22762) mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/12767) win_gpu_triggered_tests ...
6 years, 6 months ago (2014-06-11 01:39:51 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 01:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/326253002/1
6 years, 6 months ago (2014-06-11 01:47:27 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-11 02:20:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 02:21:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16010)
6 years, 6 months ago (2014-06-11 02:21:06 UTC) #11
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 03:39:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/326253002/1
6 years, 6 months ago (2014-06-11 03:40:49 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 03:41:14 UTC) #14
Message was sent while issue was closed.
Change committed as 175938

Powered by Google App Engine
This is Rietveld 408576698