ash/display/resolution_notification_controller_unittest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/display/resolution_notification_controller_unittest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Justin's comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ash/system/chromeos/managed/tray_locally_managed_user.cc » ('j') | chrome/browser/chromeos/display/display_preferences_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/display/resolution_notification_controller_unittest.cc

diff --git a/ash/display/resolution_notification_controller_unittest.cc b/ash/display/resolution_notification_controller_unittest.cc

index 4d1eedf648ced2841c6ac6c44c5c6d0fcfca8c86..62d2bd34ace260ae770d60bdee7221e1b30d96a4 100644

--- a/ash/display/resolution_notification_controller_unittest.cc

+++ b/ash/display/resolution_notification_controller_unittest.cc

@@ -123,8 +123,8 @@ class ResolutionNotificationControllerTest : public ash::test::AshTestBase {

}

static bool IsNotificationVisible() {

- return message_center::MessageCenter::Get()->HasNotification(

- ResolutionNotificationController::kNotificationId);

+ return message_center::MessageCenter::Get()->FindVisibleNotificationById(

+ ResolutionNotificationController::kNotificationId) != NULL;

James Cook 2014/06/09 22:10:23 No need for comparison to NULL here or anywhere el

juyik 2014/06/09 22:46:41 Done.

}

static void TickTimer() {

« no previous file with comments | « no previous file | ash/system/chromeos/managed/tray_locally_managed_user.cc » ('j') | chrome/browser/chromeos/display/display_preferences_unittest.cc » ('J')