chrome/browser/chromeos/display/display_preferences_unittest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/display/display_preferences_unittest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Justin's comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/display/resolution_notification_controller_unittest.cc ('K') | « ash/system/web_notification/web_notification_tray_unittest.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/display/display_preferences_unittest.cc

diff --git a/chrome/browser/chromeos/display/display_preferences_unittest.cc b/chrome/browser/chromeos/display/display_preferences_unittest.cc

index 7d889f04103dc7d0473d4df0b2126445d946f4b7..6f179cf24faacc33e3d8bf63ded8505847118813 100644

--- a/chrome/browser/chromeos/display/display_preferences_unittest.cc

+++ b/chrome/browser/chromeos/display/display_preferences_unittest.cc

@@ -438,8 +438,8 @@ TEST_F(DisplayPreferencesTest, PreventStore) {

message_center::MessageCenter::Get()->ClickOnNotificationButton(

ResolutionNotificationController::kNotificationId, 1);

RunAllPendingInMessageLoop();

- EXPECT_FALSE(message_center::MessageCenter::Get()->HasNotification(

- ResolutionNotificationController::kNotificationId));

+ EXPECT_TRUE(message_center::MessageCenter::Get()->FindVisibleNotificationById(

James Cook 2014/06/09 22:10:23 EXPECT_FALSE(message_center::MessageCenter::Get()-

juyik 2014/06/09 22:46:41 Done.

+ ResolutionNotificationController::kNotificationId) == NULL);

// Once the notification is removed, the specified resolution will be stored

// by SetDisplayResolution.