The 1st patch to disambiguate message center notifications

ash/display/resolution_notification_controller_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/resolution_notification_controller.h"
 
 #include "ash/display/display_manager.h"
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
@@ skipping 105 matching lines @@
     message_center::MessageCenter::Get()->ClickOnNotificationButton(
         ResolutionNotificationController::kNotificationId, index);
   }
 
   static void CloseNotification() {
     message_center::MessageCenter::Get()->RemoveNotification(
         ResolutionNotificationController::kNotificationId, true /* by_user */);
   }
 
   static bool IsNotificationVisible() {
-    return message_center::MessageCenter::Get()->HasNotification(
-        ResolutionNotificationController::kNotificationId);
+    return message_center::MessageCenter::Get()->FindVisibleNotificationById(
+        ResolutionNotificationController::kNotificationId) != NULL;

[James Cook, 2014/06/09 22:10:23]

No need for comparison to NULL here or anywhere else.

[juyik, 2014/06/09 22:46:41]

Done.

   }
 
   static void TickTimer() {
     controller()->OnTimerTick();
   }
 
   static ResolutionNotificationController* controller() {
     return Shell::GetInstance()->resolution_notification_controller();
   }
 
@@ skipping 266 matching lines @@
   ClickOnNotificationButton(0);
   RunAllPendingInMessageLoop();
   EXPECT_FALSE(IsNotificationVisible());
   EXPECT_EQ(0, accept_count());
   EXPECT_TRUE(display_manager->GetSelectedModeForDisplayId(id2, &mode));
   EXPECT_EQ("250x250", mode.size.ToString());
   EXPECT_EQ(58.0f, mode.refresh_rate);
 }
 
 }  // namespace ash