chrome/browser/notifications/extension_welcome_notification_unittest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification_unittest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc ('K') | « chrome/browser/notifications/extension_welcome_notification.cc ('k') | chrome/browser/notifications/message_center_notification_manager.cc » ('j') | ui/message_center/notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification_unittest.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification_unittest.cc b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

index 487eaf9620442ce6318c428d1590778f06025c5d..6e037ad5b94118c6cf6d09e727513718fdc75232 100644

--- a/chrome/browser/notifications/extension_welcome_notification_unittest.cc

+++ b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

@@ -40,8 +40,11 @@ class MockMessageCenter : public message_center::FakeMessageCenter {

}

// message_center::FakeMessageCenter Overrides

- virtual bool HasNotification(const std::string& id) OVERRIDE {

- return last_notification.get() && (last_notification->id() == id);

+ virtual message_center::Notification* FindVisibleNotificationById(

+ const std::string& id) OVERRIDE {

+ if (last_notification.get() && last_notification->id() == id)

+ return last_notification.get();

+ return NULL;

}

virtual void AddNotification(