chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc ('k') | chrome/browser/notifications/extension_welcome_notification.cc » ('j') | ui/message_center/notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc b/chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc

index b502658d5b456b5bad28bfa64903a7cb20b0e1d2..cf2a96d14ef62e7210cde23d422c18200c71a0b8 100644

--- a/chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc

+++ b/chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc

@@ -20,7 +20,8 @@ const char* kNotificationId =

NetworkPortalNotificationController::kNotificationId;

bool HasNotification() {

- return MessageCenter::Get()->HasNotification(kNotificationId);

+ return MessageCenter::Get()->FindVisibleNotificationById(kNotificationId) !=

dewittj 2014/06/09 19:59:10 prefer to split this into two statements

juyik 2014/06/09 21:28:08 Done.

+ NULL;

}

class NotificationObserver : public message_center::MessageCenterObserver {