Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: ui/message_center/notification.h

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/notification.h
diff --git a/ui/message_center/notification.h b/ui/message_center/notification.h
index a0bc853e616beeef9dfb581c0b53d0a642758bdc..c00d5d6f96af9f867907d30873762b07c2f4a7b0 100644
--- a/ui/message_center/notification.h
+++ b/ui/message_center/notification.h
@@ -64,8 +64,12 @@ class MESSAGE_CENTER_EXPORT Notification {
const RichNotificationData& optional_fields,
NotificationDelegate* delegate);
+ Notification(const std::string& id, const Notification& other);
dewittj 2014/06/09 20:00:30 by the way, are you using this new constructor in
juyik 2014/06/09 21:28:08 Done.
+
Notification(const Notification& other);
+
Notification& operator=(const Notification& other);
+
virtual ~Notification();
// Copies the internal on-memory state from |base|, i.e. shown_as_popup,
@@ -75,6 +79,11 @@ class MESSAGE_CENTER_EXPORT Notification {
NotificationType type() const { return type_; }
void set_type(NotificationType type) { type_ = type; }
+ // Uniquely identifies a notification in the message center. For
+ // notification front ends that support multiple profiles, this id should
+ // identify a unique profile + frontend_notification_id combination. You can
+ // Use this id against the MessageCenter interface but not the
+ // NotificationUIManager interface.
const std::string& id() const { return id_; }
const base::string16& title() const { return title_; }

Powered by Google App Engine
This is Rietveld 408576698