chrome/browser/extensions/api/messaging/native_message_process_host.h - Issue 323683002: net: FileStream cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host.h

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add DCHECK, fix ASSERT message Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/files/file_posix.cc ('K') | « chrome/browser/chromeos/drive/local_file_reader.cc ('k') | chrome/browser/extensions/api/messaging/native_message_process_host.cc » ('j') | chrome/browser/extensions/api/messaging/native_message_process_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_process_host.h

diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host.h b/chrome/browser/extensions/api/messaging/native_message_process_host.h

index 482d3b067e5fb02ee1fc1a72fd7627b4f6fc4ba9..47fe8723fd34a8809bb6da1d98bb30eaf5405160 100644

--- a/chrome/browser/extensions/api/messaging/native_message_process_host.h

+++ b/chrome/browser/extensions/api/messaging/native_message_process_host.h

@@ -8,6 +8,7 @@

#include <queue>

#include <string>

+#include "base/files/file.h"

wtc 2014/06/19 18:20:49 Nit: we don't need this header now because there i

rvargas (doing something else) 2014/06/19 18:46:42 It is needed to define PlatformFile for read_file_

#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop/message_loop.h"

@@ -151,8 +152,6 @@ class NativeMessageProcessHost

scoped_ptr<net::FileStream> read_stream_;

#if defined(OS_POSIX)

- // TODO(rvargas): Remove these members, maybe merging the functionality to

- // net::FileStream.

base::PlatformFile read_file_;

base::MessageLoopForIO::FileDescriptorWatcher read_watcher_;

#endif // !defined(OS_POSIX)