net: FileStream cleanup

chrome/browser/extensions/api/messaging/native_message_process_host.cc

Index: chrome/browser/extensions/api/messaging/native_message_process_host.cc
diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host.cc b/chrome/browser/extensions/api/messaging/native_message_process_host.cc
index b4993dc5c8c770a607d03c9b9f529b9176e49ce8..7d7e37f40dddd6523f13624e297b3bd3b5936e56 100644
--- a/chrome/browser/extensions/api/messaging/native_message_process_host.cc
+++ b/chrome/browser/extensions/api/messaging/native_message_process_host.cc
@@ -7,7 +7,6 @@
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
-#include "base/platform_file.h"
 #include "base/prefs/pref_service.h"
 #include "base/process/kill.h"
 #include "base/threading/sequenced_worker_pool.h"
@@ -105,7 +104,7 @@ NativeMessageProcessHost::NativeMessageProcessHost(
       closed_(false),
       process_handle_(base::kNullProcessHandle),
 #if defined(OS_POSIX)
-      read_file_(base::kInvalidPlatformFileValue),
+      read_file_(-1),

[wtc, 2014/06/19 18:20:49]

Nit: the original code (base::kInvalidPlatformFileValue) seems fine to me.

[rvargas (doing something else), 2014/06/19 18:46:42]

Unfortunately, my next patch will completely remove platform_file.h, so
base::kInvalidPlatformFileValue will be undefined. After I remove that file,
base::PlatformFile is only defined by file.h, but not to keep variables of that
type (which mean initializations, checks for validity etc) but to use the
underlying handle of a base::File on a lower level call.

That's the detail about this code that I was trying to fix: for POSIX, it stores
a file descriptor that is owned by another object. What makes it acceptable is
that the owner of that file is a FileStream that this class also owns.

 #endif
       read_pending_(false),
       write_pending_(false) {