net: FileStream cleanup

base/files/file_posix.cc

Index: base/files/file_posix.cc
diff --git a/base/files/file_posix.cc b/base/files/file_posix.cc
index 0764ee98660239ed813ada6d0dd0a7b15429aeee..a51aaa812799a311376e3b8f8f0103943f84afe4 100644
--- a/base/files/file_posix.cc
+++ b/base/files/file_posix.cc
@@ -280,11 +280,16 @@ void File::Close() {
 int64 File::Seek(Whence whence, int64 offset) {
   base::ThreadRestrictions::AssertIOAllowed();
   DCHECK(IsValid());
-  if (offset < 0)
-    return -1;
 
+#if defined(OS_ANDROID)
+  COMPILE_ASSERT(sizeof(int64) == sizeof(off64_t), off64_t_64_bit);
+  return lseek64(file_.get(), static_cast<off64_t>(offset),

[wtc, 2014/06/19 18:20:49]

The COMPILE_ASSERT and the static_cast<off64_t> should be unnecessary in this
case, because by definition off64_t is 64 bits. But it's fine to have them for
symmetry with the other case.

[rvargas (doing something else), 2014/06/19 18:46:42]

That was exactly my thought :)

+                 static_cast<int>(whence));
+#else
+  COMPILE_ASSERT(sizeof(int64) == sizeof(off_t), off_t_64_bit);
   return lseek(file_.get(), static_cast<off_t>(offset),
                static_cast<int>(whence));
+#endif
 }
 
 int File::Read(int64 offset, char* data, int size) {