Issue 323663002: Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323663002: Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (Closed)

Created:
6 years, 6 months ago by abarth-chromium

Modified:
6 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit), ostap, Inactive, mlamouri (slow - plz ping)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (https://codereview.chromium.org/302553007/) Reason for revert: Caused every LayoutTest to ASSERT in every configuration. Original issue's description: > Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked. > > Existing implementation calls SetScreenOrientationForTesting and sends screen > orientation events even when the test screen orientation is locked. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275535 TBR=jochen@chromium.org,ch.dumez@samsung.com,mlamouri@chromium.org,sl.ostapenko@samsung.com NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275566

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -65 lines)			Patch
M	content/public/renderer/render_view_observer.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/public/renderer/render_view_observer.cc	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	content/renderer/screen_orientation/mock_screen_orientation_controller.h	View	4 chunks	+2 lines, -12 lines	0 comments	Download
M	content/renderer/screen_orientation/mock_screen_orientation_controller.cc	View	5 chunks	+1 line, -24 lines	0 comments	Download
M	content/test/layouttest_support.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

abarth-chromium

6 years, 6 months ago (2014-06-07 00:03:25 UTC) #1

Created Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make
sure that events are not sent when orie…