content/renderer/renderer_webkitplatformsupport_impl.cc - Issue 323663002: Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.cc

Issue 323663002: Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/renderer_webkitplatformsupport_impl.h ('k') | content/renderer/screen_orientation/mock_screen_orientation_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_webkitplatformsupport_impl.cc

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc

index ed8c78217ca66f9ed628700ea54175b3f80688b5..433cca128460c80fe3c84eeac8fa56c3714c8fa0 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.cc

+++ b/content/renderer/renderer_webkitplatformsupport_impl.cc

@@ -7,7 +7,6 @@

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/lazy_instance.h"

-#include "base/logging.h"

#include "base/memory/shared_memory.h"

#include "base/message_loop/message_loop_proxy.h"

#include "base/metrics/histogram.h"

@@ -1081,7 +1080,6 @@

// static

void RendererWebKitPlatformSupportImpl::ResetMockScreenOrientationForTesting()

{

- DCHECK(!(g_test_screen_orientation_controller == 0));

g_test_screen_orientation_controller.Get().ResetData();

}

@@ -1166,10 +1164,9 @@

// static

void RendererWebKitPlatformSupportImpl::SetMockScreenOrientationForTesting(

- RenderView* render_view,

blink::WebScreenOrientationType orientation) {

g_test_screen_orientation_controller.Get()

- .UpdateDeviceOrientation(render_view, orientation);

+ .UpdateDeviceOrientation(orientation);

}

//------------------------------------------------------------------------------