Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 323423006: Password manager internals page: Add logging for parsed forms (Closed)

Created:
6 years, 6 months ago by vabr (Chromium)
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Password manager internals page: Add logging for parsed forms The PasswordAutofillAgent::SendPasswordForms method is called both when HTML forms are just parsed, and also when they are rendered. The former is the moment when the password manager first hears about forms, and notes their presence not only for autofill, but also for matching against credentials submitted later. However, I missed the second use-case (matching submitted credentials) when I put logging there for the internals page, and so currently the progress is only logged when the forms are rendered. This CL should change this: logs are now also sent when the forms have just been parsed. I already saw issues (e.g., http://crbug.com/367768) where such additional logging would have sped up the investigation. There are no tests, because we don't which logs are generated when. BUG=347927 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Ilya, Could you please review this? Cheers, Vaclav
6 years, 6 months ago (2014-06-12 15:55:52 UTC) #1
Ilya Sherman
LGTM, thanks.
6 years, 6 months ago (2014-06-12 22:31:39 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-12 22:31:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/323423006/1
6 years, 6 months ago (2014-06-12 22:33:21 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 23:37:18 UTC) #5
Message was sent while issue was closed.
Change committed as 276848

Powered by Google App Engine
This is Rietveld 408576698