Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 323423006: Password manager internals page: Add logging for parsed forms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/common/save_password_progress_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index f9a0b25a8aec430e14cd9a335db6c59a6a95f953..2bcee9225a407b909e7dd08065143e1a581ef625 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -467,14 +467,10 @@ void PasswordAutofillAgent::FirstUserGestureObserved() {
void PasswordAutofillAgent::SendPasswordForms(blink::WebFrame* frame,
bool only_visible) {
scoped_ptr<RendererSavePasswordProgressLogger> logger;
- // From the perspective of saving passwords, only calls with |only_visible|
- // being true are important -- the decision whether to save the password is
- // only made after visible forms are known, for failed login detection. Calls
- // with |only_visible| false are important for password form autofill, which
- // is currently not part of the logging.
- if (only_visible && logging_state_active_) {
+ if (logging_state_active_) {
logger.reset(new RendererSavePasswordProgressLogger(this, routing_id()));
logger->LogMessage(Logger::STRING_SEND_PASSWORD_FORMS_METHOD);
+ logger->LogBoolean(Logger::STRING_ONLY_VISIBLE, only_visible);
}
// Make sure that this security origin is allowed to use password manager.
« no previous file with comments | « no previous file | components/autofill/core/common/save_password_progress_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698