Password manager internals page: Add logging for parsed forms

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 449 matching lines @@
   SendPasswordForms(frame, false /* only_visible */);
 }
 
 void PasswordAutofillAgent::FirstUserGestureObserved() {
   gatekeeper_.OnUserGesture();
 }
 
 void PasswordAutofillAgent::SendPasswordForms(blink::WebFrame* frame,
                                               bool only_visible) {
   scoped_ptr<RendererSavePasswordProgressLogger> logger;
-  // From the perspective of saving passwords, only calls with |only_visible|
-  // being true are important -- the decision whether to save the password is
-  // only made after visible forms are known, for failed login detection. Calls
-  // with |only_visible| false are important for password form autofill, which
-  // is currently not part of the logging.
-  if (only_visible && logging_state_active_) {
+  if (logging_state_active_) {
     logger.reset(new RendererSavePasswordProgressLogger(this, routing_id()));
     logger->LogMessage(Logger::STRING_SEND_PASSWORD_FORMS_METHOD);
+    logger->LogBoolean(Logger::STRING_ONLY_VISIBLE, only_visible);
   }
 
   // Make sure that this security origin is allowed to use password manager.
   blink::WebSecurityOrigin origin = frame->document().securityOrigin();
   if (logger) {
     logger->LogURL(Logger::STRING_SECURITY_ORIGIN,
                    GURL(origin.toString().utf8()));
   }
   if (!OriginCanAccessPasswordManager(origin)) {
     if (logger) {
@@ skipping 582 matching lines @@
     username->setSelectionRange(username_selection_start_,
                                 username->value().length());
   }
   if (!password->suggestedValue().isEmpty()) {
       password->setSuggestedValue(blink::WebString());
       password->setAutofilled(was_password_autofilled_);
   }
 }
 
 }  // namespace autofill