Rename HistoryService::NotifyRenderProcessHostDestruction

Rename HistoryService::NotifyRenderProcessHostDestruction

Rename HistoryService::NotifyRenderProcessHostDestruction to
ClearCachedDataForContextID.

BUG=371827
R=sdefresne
TBR=sky (chrome/test/base/testing_profile.cc)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276563

[sdefresne, 2014-06-10 15:51:55]

LGTM

+blundell for OWNERS

Please assign mark bug as Started and assign them to yourself to prevent
duplication of effort.

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_service.h (right):

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_service.h:131: // must tell us when they are
being destroyed so that we can clear
nit: s/destroyed/invalidated/

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_unittest.cc (right):

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_unittest.cc:905: ContextID context_id = 0;
nit: can't this function be replaced with "ContextID context_id =
reinterpret_cast<ContextID>(id);"?

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/visit...
File chrome/browser/history/visit_tracker_unittest.cc (right):

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/visit...
chrome/browser/history/visit_tracker_unittest.cc:33: ContextID context_id = 0;
nit: same here, I think a reinterpret_cast would be simpler.

[blundell, 2014-06-11 12:17:48]

LGTM with changes

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
File chrome/browser/history/history_backend.h (left):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
chrome/browser/history/history_backend.h:139: // Updates the database backend
with a page's ending time stamp information.
This comment can stay with "pointer to a RenderProcessHost" replaced by
"ContextID".

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
File chrome/browser/history/history_backend.h (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
chrome/browser/history/history_backend.h:129: void
ClearCachedDataForContextID(ContextID context_id);
This should have a comment specifying what the function does.

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
File chrome/browser/history/history_service.h (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
chrome/browser/history/history_service.h:132: // out any cached data associated
with that scope.
s/scope/context

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/v...
File chrome/browser/history/visit_tracker_unittest.cc (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/v...
chrome/browser/history/visit_tracker_unittest.cc:120: // Say that context has
been destroyed.
s/destroyed/invalidated

[方觉(Fang Jue), 2014-06-11 12:41:47]

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_service.h (right):

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_service.h:131: // must tell us when they are
being destroyed so that we can clear
On 2014/06/10 15:51:54, sdefresne wrote:
> nit: s/destroyed/invalidated/

Done.

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_unittest.cc (right):

https://codereview.chromium.org/322983003/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_unittest.cc:905: ContextID context_id = 0;
n 2014/06/10 15:51:54, sdefresne wrote:
> nit: can't this function be replaced with "ContextID context_id =
> reinterpret_cast<ContextID>(id);"?

I looked at the history of this file and it was written in this way since the
beginning. Some other unittest files simply use reinterpret_cast.

Google C++ Style says 'Use reinterpret_cast to do unsafe conversions of pointer
types to and from integer and other pointer types. Use this only if you know
what you are doing and you understand the aliasing issues.' It seems that we can
use reinterpret_cast here.

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
File chrome/browser/history/history_backend.h (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
chrome/browser/history/history_backend.h:60: // here, see the history service
for behavior.
I removed comments of ClearCachedDataForContextID and UpdateWithPageEndTime
because of this comment. They're both the implementations of
ClearCachedDataForContextID and UpdateWithPageEndTime in HistoryService.

WDYT?

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
File chrome/browser/history/history_service.h (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/h...
chrome/browser/history/history_service.h:132: // out any cached data associated
with that scope.
On 2014/06/11 12:17:48, blundell wrote:
> s/scope/context

Done.

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/v...
File chrome/browser/history/visit_tracker_unittest.cc (right):

https://codereview.chromium.org/322983003/diff/20001/chrome/browser/history/v...
chrome/browser/history/visit_tracker_unittest.cc:120: // Say that context has
been destroyed.
On 2014/06/11 12:17:48, blundell wrote:
> s/destroyed/invalidated

Done.

[blundell, 2014-06-11 12:58:20]

LGTM

[方觉(Fang Jue), 2014-06-11 13:05:23]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-11 13:06:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322983003/40001

[方觉(Fang Jue), 2014-06-11 13:13:16]

The CQ bit was unchecked by fangjue23303@gmail.com

[方觉(Fang Jue), 2014-06-11 13:21:50]

TBR sky for chrome/test/base/testing_profile.cc.

[方觉(Fang Jue), 2014-06-11 15:09:02]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-11 15:12:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322983003/40001

[sky, 2014-06-11 16:25:37]

chrome/test/base/testing_profile.cc LGTM

[commit-bot: I haz the power, 2014-06-11 20:59:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:14:49]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[方觉(Fang Jue), 2014-06-12 01:59:54]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-12 02:02:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322983003/40001

[commit-bot: I haz the power, 2014-06-12 02:19:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-12 02:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 02:23:26]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[方觉(Fang Jue), 2014-06-12 02:45:20]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-12 02:48:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322983003/40001

[commit-bot: I haz the power, 2014-06-12 07:31:22]

Change committed as 276563