Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4055)

Unified Diff: chrome/browser/history/visit_tracker.cc

Issue 322983003: Rename HistoryService::NotifyRenderProcessHostDestruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/visit_tracker.h ('k') | chrome/browser/history/visit_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/visit_tracker.cc
diff --git a/chrome/browser/history/visit_tracker.cc b/chrome/browser/history/visit_tracker.cc
index 1dc2f1822f232af42445b181482bf549fbd37994..fe06075c2f332e14623173726405758afc870999 100644
--- a/chrome/browser/history/visit_tracker.cc
+++ b/chrome/browser/history/visit_tracker.cc
@@ -20,7 +20,7 @@ VisitTracker::VisitTracker() {
}
VisitTracker::~VisitTracker() {
- STLDeleteContainerPairSecondPointers(hosts_.begin(), hosts_.end());
+ STLDeleteContainerPairSecondPointers(contexts_.begin(), contexts_.end());
}
// This function is potentially slow because it may do up to two brute-force
@@ -28,15 +28,15 @@ VisitTracker::~VisitTracker() {
// relatively small number by CleanupTransitionList so it shouldn't be a big
// deal. However, if this ends up being noticable for performance, we may want
// to optimize lookup.
-VisitID VisitTracker::GetLastVisit(const void* host,
+VisitID VisitTracker::GetLastVisit(ContextID context_id,
int32 page_id,
const GURL& referrer) {
- if (referrer.is_empty() || !host)
+ if (referrer.is_empty() || !context_id)
return 0;
- HostList::iterator i = hosts_.find(host);
- if (i == hosts_.end())
- return 0; // We don't have any entries for this host.
+ ContextList::iterator i = contexts_.find(context_id);
+ if (i == contexts_.end())
+ return 0; // We don't have any entries for this context.
TransitionList& transitions = *i->second;
// Recall that a page ID is associated with a single session history entry.
@@ -66,14 +66,14 @@ VisitID VisitTracker::GetLastVisit(const void* host,
return 0;
}
-void VisitTracker::AddVisit(const void* host,
+void VisitTracker::AddVisit(ContextID context_id,
int32 page_id,
const GURL& url,
VisitID visit_id) {
- TransitionList* transitions = hosts_[host];
+ TransitionList* transitions = contexts_[context_id];
if (!transitions) {
transitions = new TransitionList;
- hosts_[host] = transitions;
+ contexts_[context_id] = transitions;
}
Transition t;
@@ -85,13 +85,13 @@ void VisitTracker::AddVisit(const void* host,
CleanupTransitionList(transitions);
}
-void VisitTracker::NotifyRenderProcessHostDestruction(const void* host) {
- HostList::iterator i = hosts_.find(host);
- if (i == hosts_.end())
- return; // We don't have any entries for this host.
+void VisitTracker::ClearCachedDataForContextID(ContextID context_id) {
+ ContextList::iterator i = contexts_.find(context_id);
+ if (i == contexts_.end())
+ return; // We don't have any entries for this context.
delete i->second;
- hosts_.erase(i);
+ contexts_.erase(i);
}
« no previous file with comments | « chrome/browser/history/visit_tracker.h ('k') | chrome/browser/history/visit_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698