Rename HistoryService::NotifyRenderProcessHostDestruction

chrome/browser/history/history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 39 matching lines @@
 // *See the .cc file for more information on the design.*
 //
 // Internal history implementation which does most of the work of the history
 // system. This runs on a background thread (to not block the browser when we
 // do expensive operations) and is NOT threadsafe, so it must only be called
 // from message handlers on the background thread. Invoking on another thread
 // requires threadsafe refcounting.
 //
 // Most functions here are just the implementations of the corresponding
 // functions in the history service. These functions are not documented
 // here, see the history service for behavior.

[方觉(Fang Jue), 2014/06/11 12:41:47]

I removed comments of ClearCachedDataForContextID and UpdateWithPageEndTime
because of this comment. They're both the implementations of
ClearCachedDataForContextID and UpdateWithPageEndTime in HistoryService.

WDYT?

 class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
                        public BroadcastNotificationDelegate {
  public:
   // Interface implemented by the owner of the HistoryBackend object. Normally,
   // the history service implements this to send stuff back to the main thread.
   // The unit tests can provide a different implementation if they don't have
   // a history service object.
   class Delegate {
    public:
     virtual ~Delegate() {}
@@ skipping 48 matching lines @@
   // |languages| gives a list of language encodings with which the history
   // URLs and omnibox searches are interpreted.
   // |force_fail| can be set during unittests to unconditionally fail to init.
   void Init(const std::string& languages, bool force_fail);
 
   // Notification that the history system is shutting down. This will break
   // the refs owned by the delegate and any pending transaction so it will
   // actually be deleted.
   void Closing();
 
-  // See NotifyRenderProcessHostDestruction.
-  void NotifyRenderProcessHostDestruction(const void* host);
+  void ClearCachedDataForContextID(ContextID context_id);

[blundell, 2014/06/11 12:17:48]

This should have a comment specifying what the function does.

 
   // Navigation ----------------------------------------------------------------
 
   // |request.time| must be unique with high probability.
   void AddPage(const HistoryAddPageArgs& request);
   virtual void SetPageTitle(const GURL& url, const base::string16& title);
   void AddPageNoVisitForBookmark(const GURL& url, const base::string16& title);
-
-  // Updates the database backend with a page's ending time stamp information.

[blundell, 2014/06/11 12:17:48]

This comment can stay with "pointer to a RenderProcessHost" replaced by
"ContextID".

-  // The page can be identified by the combination of the pointer to
-  // a RenderProcessHost, the page id and the url.
-  //
-  // The given pointer will not be dereferenced, it is only used for
-  // identification purposes, hence it is a void*.
-  void UpdateWithPageEndTime(const void* host,
+  void UpdateWithPageEndTime(ContextID context_id,
                              int32 page_id,
                              const GURL& url,
                              base::Time end_ts);
 
   // Querying ------------------------------------------------------------------
 
   // ScheduleAutocomplete() never frees |provider| (which is globally live).
   // It passes |params| on to the autocomplete system which will eventually
   // free it.
   void ScheduleAutocomplete(HistoryURLProvider* provider,
@@ skipping 723 matching lines @@
 
   // Listens for the system being under memory pressure.
   scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_