Issue 3225004: Move all the remaining dependencies in webcore_remaining into webcore_prerequisites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3225004: Move all the remaining dependencies in webcore_remaining into webcore_prerequisites (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Victor Wang

Base URL:
git://git.webkit.org/WebKit.git

Visibility:
Public.

Move all the remaining dependencies in webcore_remaining into webcore_prerequisites dependent on http://codereview.chromium.org/3223009 is: https://bugs.webkit.org/show_bug.cgi?id=44814

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -17 lines)			Patch
	M	WebCore/ChangeLog	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	WebCore/WebCore.gyp/WebCore.gyp	View	1 2 3	7 chunks	+34 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

Victor Wang

On 2010/08/29 18:59:50, Marc-Antoine Ruel wrote: > Code compiles. > > kthxbye LGTM

10 years, 3 months ago (2010-08-29 19:58:00 UTC) #2

Mark Mentovai

10 years, 3 months ago (2010-08-30 01:25:25 UTC) #3

LGTM

If you still have a testcase for the include_dirs problem with Objective-C++ on
the Mac, please let me know.