Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 3223009: Move more common settings to webcore_prerequisites (Closed)

Created:
10 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Base URL:
git://git.webkit.org/WebKit.git
Visibility:
Public.

Description

Move more common settings to webcore_prerequisites dependent on http://codereview.chromium.org/3278002 is https://bugs.webkit.org/show_bug.cgi?id=44812

Patch Set 1 #

Patch Set 2 : fix build for mac #

Patch Set 3 : comment #

Patch Set 4 : . #

Patch Set 5 : This version fixes ordering on mac #

Patch Set 6 : rebased on head #

Patch Set 7 : fix mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -113 lines) Patch
M WebCore/ChangeLog View 1 chunk +31 lines, -0 lines 0 comments Download
M WebCore/WebCore.gyp/WebCore.gyp View 1 2 3 4 5 6 9 chunks +177 lines, -113 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Mentovai
LGTM
10 years, 3 months ago (2010-08-28 03:24:02 UTC) #2
Victor Wang
LGTM
10 years, 3 months ago (2010-08-28 03:38:02 UTC) #3
M-A Ruel
In fact this doesn't work. For an unknown reason the dependency tree is wrong. In ...
10 years, 3 months ago (2010-08-28 03:47:42 UTC) #4
M-A Ruel
Fixed the issue by putting hard_dependency:1 in webkit_system_interface. I'm not sure about it but it ...
10 years, 3 months ago (2010-08-28 04:19:41 UTC) #5
Victor Wang
LGTM On 2010/08/28 04:19:41, Marc-Antoine Ruel wrote: > Fixed the issue by putting hard_dependency:1 in ...
10 years, 3 months ago (2010-08-28 04:23:14 UTC) #6
M-A Ruel
10 years, 3 months ago (2010-08-29 14:57:07 UTC) #7
Actually the last change didn't work either.

Mark, it seems that defining includes_dir in direct_dependent_settings works for
C++ but not for Objective-C. I can try to write a regression test for that if
you want but you can just try the patchset were I don't duplicate includes_dir,
you'll see it .mm file fails to compile in webcore_remaining.

Powered by Google App Engine
This is Rietveld 408576698