Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322433005: Use woff2 decoder in blink (Closed)

Created:
6 years, 6 months ago by bashi
Modified:
4 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use woff2 decoder in blink To remove woff2 logic from ots. BUG=371267

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary include #

Patch Set 3 : Rebase #

Patch Set 4 : GN fix #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M Source/platform/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/fonts/opentype/OpenTypeSanitizer.cpp View 1 2 2 chunks +42 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
bashi
Uploaded a CL for test separately. https://codereview.chromium.org/316343004/
6 years, 6 months ago (2014-06-06 08:12:37 UTC) #1
bashi
Sorry, I need to fix compiler error on Win first. https://codereview.chromium.org/315393005
6 years, 6 months ago (2014-06-06 08:48:18 UTC) #2
Kunihiko Sakamoto
lgtm https://codereview.chromium.org/322433005/diff/1/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp File Source/platform/fonts/opentype/OpenTypeSanitizer.cpp (right): https://codereview.chromium.org/322433005/diff/1/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp#newcode38 Source/platform/fonts/opentype/OpenTypeSanitizer.cpp:38: #include "third_party/brotli/src/woff2/woff2_common.h" Is this necessary?
6 years, 6 months ago (2014-06-06 09:41:26 UTC) #3
bashi
https://codereview.chromium.org/322433005/diff/1/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp File Source/platform/fonts/opentype/OpenTypeSanitizer.cpp (right): https://codereview.chromium.org/322433005/diff/1/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp#newcode38 Source/platform/fonts/opentype/OpenTypeSanitizer.cpp:38: #include "third_party/brotli/src/woff2/woff2_common.h" On 2014/06/06 09:41:26, Kunihiko Sakamoto wrote: > ...
6 years, 6 months ago (2014-06-06 09:52:15 UTC) #4
bashi
@dglazkov, could you take another look?
6 years, 6 months ago (2014-06-13 00:08:15 UTC) #5
bashi
On 2014/06/13 00:08:15, bashi1 wrote: > @dglazkov, could you take another look? ping?
6 years, 6 months ago (2014-06-16 23:04:25 UTC) #6
bashi
On 2014/06/16 23:04:25, bashi1 wrote: > On 2014/06/13 00:08:15, bashi1 wrote: > > @dglazkov, could ...
6 years, 6 months ago (2014-06-23 23:39:14 UTC) #7
bashi
I'd like to revisit this CL. This blocks ksakamoto@'s ots roll for https://codereview.chromium.org/512923003/
6 years, 2 months ago (2014-09-26 04:00:35 UTC) #8
bashi
jamesr@, could you take a look (or suggest reviewers)?
6 years, 2 months ago (2014-09-26 04:02:45 UTC) #10
bashi
I'd appreciate if you could suggest reviewers when you don't have time.
6 years, 2 months ago (2014-09-30 03:35:44 UTC) #11
jamesr
Sorry, I think I've already said I don't know anything about woff.
6 years, 2 months ago (2014-09-30 05:01:57 UTC) #13
pdr.
@bashi, I've added eae to this review. Emil knows this area, or knows who does.
6 years, 2 months ago (2014-09-30 05:08:50 UTC) #15
bashi
OK. Thanks. @dglazkov, could you review this CL? Sorry for asking this many times.
6 years, 2 months ago (2014-09-30 05:09:10 UTC) #16
bashi
6 years, 2 months ago (2014-09-30 05:09:43 UTC) #17 
On 2014/09/30 05:08:50, pdr wrote:
> @bashi, I've added eae to this review. Emil knows this area, or knows who
does.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698