Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 512923003: Fix MSVC warnings about possible value truncation. (Closed)

Created:
6 years, 3 months ago by Peter Kasting
Modified:
6 years, 2 months ago
CC:
chromium-reviews, bashi
Base URL:
https://chromium.googlesource.com/external/ots.git@master
Visibility:
Public.

Description

Fix MSVC warnings about possible value truncation. BUG=81439 TEST=none

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -117 lines) Patch
M src/cff.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/cff_type2_charstring.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/cmap.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/gasp.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/hdmx.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M src/kern.cc View 1 2 2 chunks +13 lines, -9 lines 0 comments Download
M src/loca.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/ltsh.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/name.cc View 1 2 6 chunks +14 lines, -10 lines 0 comments Download
M src/ots.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/post.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M src/vorg.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M src/woff2.cc View 1 2 3 22 chunks +62 lines, -61 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Peter Kasting
pkasting@chromium.org changed reviewers: + yusukes@chromium.org
6 years, 3 months ago (2014-08-28 01:02:38 UTC) #1
Peter Kasting
These warnings are not on by default yet, but I'm trying to enable them. I ...
6 years, 3 months ago (2014-08-28 01:02:38 UTC) #2
Peter Kasting
Ping yusukes
6 years, 3 months ago (2014-09-10 22:44:18 UTC) #3
Peter Kasting
On 2014/09/10 22:44:18, Peter Kasting wrote: > Ping yusukes Ping?
6 years, 3 months ago (2014-09-25 06:03:03 UTC) #4
Yusuke Sato
LGTM Sorry for the delay. I somehow missed this. Since I'm no longer working on ...
6 years, 3 months ago (2014-09-25 06:18:51 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-09-25 08:25:13 UTC) #8
Peter Kasting
Behdad, can you land this for me, or tell me how to land it? As ...
6 years, 2 months ago (2014-09-25 21:15:48 UTC) #10
behdad_google
On 2014/09/25 21:15:48, Peter Kasting wrote: > Behdad, can you land this for me, or ...
6 years, 2 months ago (2014-09-25 21:37:57 UTC) #11
Kunihiko Sakamoto
lgtm Thanks. I will land this. (Currently I and bashi@ maintain googlecode OTS.)
6 years, 2 months ago (2014-09-26 03:32:34 UTC) #13
Kunihiko Sakamoto
Committed manually as r116 https://code.google.com/p/ots/source/detail?r=116
6 years, 2 months ago (2014-09-26 03:56:02 UTC) #14
behdad_google
6 years, 2 months ago (2014-09-29 15:00:55 UTC) #15
Message was sent while issue was closed.
On 2014/09/26 03:56:02, Kunihiko Sakamoto wrote:
> Committed manually as r116
> 
> https://code.google.com/p/ots/source/detail?r=116

Thanks.  Got integrated in the github repo as well.

Powered by Google App Engine
This is Rietveld 408576698