FBTF: Move code from headers into cc files.

FBTF: Move code from headers into cc files.

BUG=none
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57732

[Elliot Glaysher, 2010-08-27 19:40:32]

Moving several of the bigger constructors really does help, but half this patch
is me just being anal retentive.

[jamesr, 2010-08-27 19:50:26]

Yes! (assuming it blends on the trybots).

LGTM+++

[tony, 2010-08-27 20:24:48]

LGTM2

http://codereview.chromium.org/3219002/diff/1/9
File webkit/glue/form_field.h (right):

http://codereview.chromium.org/3219002/diff/1/9#newcode25
webkit/glue/form_field.h:25: ~FormField();
Nit: In the case of a non-virtual empty destructor, is it just for completeness?
 I imagine it would be faster to compile/link to not explicitly declare
(although marginally so).

[jamesr, 2010-08-27 20:28:44]

http://codereview.chromium.org/3219002/diff/1/9
File webkit/glue/form_field.h (right):

http://codereview.chromium.org/3219002/diff/1/9#newcode25
webkit/glue/form_field.h:25: ~FormField();
On 2010/08/27 20:24:48, tony wrote:
> Nit: In the case of a non-virtual empty destructor, is it just for
completeness?
>  I imagine it would be faster to compile/link to not explicitly declare
> (although marginally so).

If it's not explicitly declared then you get the compiler's default version
(with definition).

[Elliot Glaysher, 2010-08-27 21:02:45]

http://codereview.chromium.org/3219002/diff/1/9
File webkit/glue/form_field.h (right):

http://codereview.chromium.org/3219002/diff/1/9#newcode25
webkit/glue/form_field.h:25: ~FormField();
This is not an empty destructor. The destructor, even though declared as {},
will make five function calls minimum.

[darin (slow to review), 2010-08-27 21:28:35]

Thank you for doing this!  LGTM

http://codereview.chromium.org/3219002/diff/1/9
File webkit/glue/form_field.h (right):

http://codereview.chromium.org/3219002/diff/1/9#newcode25
webkit/glue/form_field.h:25: ~FormField();
On 2010/08/27 21:02:45, Elliot Glaysher wrote:
> This is not an empty destructor. The destructor, even though declared as {},
> will make five function calls minimum.

Agreed.  This is a good case to move into the .cc file.  Just look at the member
vars!