Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: webkit/glue/form_field.h

Issue 3219002: FBTF: Move code from headers into cc files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/form_data.cc ('k') | webkit/glue/form_field.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/form_field.h
diff --git a/webkit/glue/form_field.h b/webkit/glue/form_field.h
index 2a1ffcfeaf9536360950cbcc632e95e227cf29bc..56d89697a5293d556858fddd68f3d13a10d00985 100644
--- a/webkit/glue/form_field.h
+++ b/webkit/glue/form_field.h
@@ -22,6 +22,7 @@ class FormField {
const string16& value,
const string16& form_control_type,
int size);
+ ~FormField();
tony 2010/08/27 20:24:48 Nit: In the case of a non-virtual empty destructor
jamesr 2010/08/27 20:28:44 If it's not explicitly declared then you get the c
Elliot Glaysher 2010/08/27 21:02:45 This is not an empty destructor. The destructor, e
darin (slow to review) 2010/08/27 21:28:35 Agreed. This is a good case to move into the .cc
const string16& label() const { return label_; }
const string16& name() const { return name_; }
« no previous file with comments | « webkit/glue/form_data.cc ('k') | webkit/glue/form_field.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698