FBTF: Move code from headers into cc files.

webkit/glue/form_field.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_GLUE_FORM_FIELD_H_
 #define WEBKIT_GLUE_FORM_FIELD_H_
 
 #include <vector>
 
 #include "base/string16.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebFormControlElement.h"
 
 namespace webkit_glue {
 
 // Stores information about a field in a form.
 class FormField {
  public:
   FormField();
   explicit FormField(WebKit::WebFormControlElement element);
   FormField(const string16& label,
             const string16& name,
             const string16& value,
             const string16& form_control_type,
             int size);
+  ~FormField();

[tony, 2010/08/27 20:24:48]

Nit: In the case of a non-virtual empty destructor, is it just for completeness?
 I imagine it would be faster to compile/link to not explicitly declare
(although marginally so).

[jamesr, 2010/08/27 20:28:44]

If it's not explicitly declared then you get the compiler's default version
(with definition).

[Elliot Glaysher, 2010/08/27 21:02:45]

This is not an empty destructor. The destructor, even though declared as {},
will make five function calls minimum.

[darin (slow to review), 2010/08/27 21:28:35]

Agreed.  This is a good case to move into the .cc file.  Just look at the member
vars!

 
   const string16& label() const { return label_; }
   const string16& name() const { return name_; }
   const string16& value() const { return value_; }
   const string16& form_control_type() const { return form_control_type_; }
   int size() const { return size_; }
   // Returns option string for elements for which they make sense (select-one,
   // for example) for the rest of elements return an empty array.
   const std::vector<string16>& option_strings() const {
     return option_strings_;
@@ skipping 29 matching lines @@
   int size_;
   std::vector<string16> option_strings_;
 };
 
 // So we can compare FormFields with EXPECT_EQ().
 std::ostream& operator<<(std::ostream& os, const FormField& profile);
 
 }  // namespace webkit_glue
 
 #endif  // WEBKIT_GLUE_FORM_FIELD_H_