Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions

Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions (Closed)

Created:
6 years, 6 months ago by Devlin

Modified:
6 years, 6 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Separate PermissionsData::CanExecuteScriptOnPage into two functions CanExecuteScriptOnPage is currently being used for both content script permissions and generic access (tabs api, etc). Instead, since these have two purposes, there should be two functions. BUG=379356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275568

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -197 lines)			Patch
M	chrome/browser/extensions/active_tab_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/automation_internal/automation_internal_api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/tabs/tabs_api.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/web_request/web_request_permissions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_permissions_policy_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_permissions_policy_delegate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc	View		1 chunk	+12 lines, -14 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	1	1 chunk	+24 lines, -60 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/renderer_permissions_policy_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/renderer_permissions_policy_delegate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc	View		3 chunks	+10 lines, -10 lines	0 comments	Download
M	extensions/common/permissions/permissions_data.h	View	1	3 chunks	+35 lines, -15 lines	0 comments	Download
M	extensions/common/permissions/permissions_data.cc	View	1	2 chunks	+78 lines, -62 lines	0 comments	Download
M	extensions/common/permissions/permissions_data_unittest.cc	View		5 chunks	+11 lines, -11 lines	0 comments	Download
M	extensions/renderer/script_injection.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	extensions/renderer/user_script_scheduler.cc	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm! https://codereview.chromium.org/321533003/diff/1/extensions/common/permissions/permissions_data.h File extensions/common/permissions/permissions_data.h (right): https://codereview.chromium.org/321533003/diff/1/extensions/common/permissions/permissions_data.h#newcode142 extensions/common/permissions/permissions_data.h:142: // with the reason the extension cannot script ...

6 years, 6 months ago (2014-06-06 18:46:52 UTC) #2

Devlin

https://codereview.chromium.org/321533003/diff/1/extensions/common/permissions/permissions_data.h File extensions/common/permissions/permissions_data.h (right): https://codereview.chromium.org/321533003/diff/1/extensions/common/permissions/permissions_data.h#newcode142 extensions/common/permissions/permissions_data.h:142: // with the reason the extension cannot script the ...

6 years, 6 months ago (2014-06-06 19:25:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/321533003/20001

6 years, 6 months ago (2014-06-06 19:26:29 UTC) #5

Message was sent while issue was closed.

Change committed as 275568

Expand Messages | Collapse Messages