Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | extensions/renderer/script_injection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data_unittest.cc
diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc
index f7fad22953167edb19fd4a07003960367aa8033b..d737944ffa24bb5e05d7a5ac9ef27c7b2fefbb03 100644
--- a/extensions/common/permissions/permissions_data_unittest.cc
+++ b/extensions/common/permissions/permissions_data_unittest.cc
@@ -311,7 +311,7 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) {
#endif
}
-// Base class for testing the CanExecuteScriptOnPage and CanCaptureVisiblePage
+// Base class for testing the CanAccessPage and CanCaptureVisiblePage
// methods of Extension for extensions with various permissions.
class ExtensionScriptAndCaptureVisibleTest : public testing::Test {
protected:
@@ -345,14 +345,14 @@ class ExtensionScriptAndCaptureVisibleTest : public testing::Test {
bool AllowedScript(const Extension* extension, const GURL& url,
const GURL& top_url, int tab_id) {
- return extension->permissions_data()->CanExecuteScriptOnPage(
- extension, url, top_url, tab_id, NULL, -1, NULL);
+ return extension->permissions_data()->CanAccessPage(
+ extension, url, top_url, tab_id, -1, NULL);
}
bool BlockedScript(const Extension* extension, const GURL& url,
const GURL& top_url) {
- return !extension->permissions_data()->CanExecuteScriptOnPage(
- extension, url, top_url, -1, NULL, -1, NULL);
+ return !extension->permissions_data()->CanAccessPage(
+ extension, url, top_url, -1, -1, NULL);
}
bool Allowed(const Extension* extension, const GURL& url) {
@@ -360,8 +360,8 @@ class ExtensionScriptAndCaptureVisibleTest : public testing::Test {
}
bool Allowed(const Extension* extension, const GURL& url, int tab_id) {
- return (extension->permissions_data()->CanExecuteScriptOnPage(
- extension, url, url, tab_id, NULL, -1, NULL) &&
+ return (extension->permissions_data()->CanAccessPage(
+ extension, url, url, tab_id, -1, NULL) &&
extension->permissions_data()->CanCaptureVisiblePage(tab_id, NULL));
}
@@ -370,8 +370,8 @@ class ExtensionScriptAndCaptureVisibleTest : public testing::Test {
}
bool CaptureOnly(const Extension* extension, const GURL& url, int tab_id) {
- return !extension->permissions_data()->CanExecuteScriptOnPage(
- extension, url, url, tab_id, NULL, -1, NULL) &&
+ return !extension->permissions_data()->CanAccessPage(
+ extension, url, url, tab_id, -1, NULL) &&
extension->permissions_data()->CanCaptureVisiblePage(tab_id, NULL);
}
@@ -391,8 +391,8 @@ class ExtensionScriptAndCaptureVisibleTest : public testing::Test {
}
bool Blocked(const Extension* extension, const GURL& url, int tab_id) {
- return !(extension->permissions_data()->CanExecuteScriptOnPage(
- extension, url, url, tab_id, NULL, -1, NULL) ||
+ return !(extension->permissions_data()->CanAccessPage(
+ extension, url, url, tab_id, -1, NULL) ||
extension->permissions_data()->CanCaptureVisiblePage(tab_id,
NULL));
}
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | extensions/renderer/script_injection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698