Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
index 6c7e8d4aacc6dc077c197ae4643e68764d0f10d8..aba1f6f0a03066dbef5a0859934a09dd7dbb0cee 100644
--- a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
+++ b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
@@ -75,21 +75,19 @@ TEST_F(BrowserPermissionsPolicyDelegateTest, CanExecuteScriptOnPage) {
// The same call should succeed with a normal process, but fail with a signin
// process.
const PermissionsData* permissions_data = extension->permissions_data();
- EXPECT_TRUE(permissions_data->CanExecuteScriptOnPage(extension,
- kSigninUrl,
- kSigninUrl,
- -1,
- NULL,
- normal_process.GetID(),
- &error))
+ EXPECT_TRUE(permissions_data->CanAccessPage(extension,
+ kSigninUrl,
+ kSigninUrl,
+ -1, // no tab id.
+ normal_process.GetID(),
+ &error))
<< error;
- EXPECT_FALSE(permissions_data->CanExecuteScriptOnPage(extension,
- kSigninUrl,
- kSigninUrl,
- -1,
- NULL,
- signin_process.GetID(),
- &error))
+ EXPECT_FALSE(permissions_data->CanAccessPage(extension,
+ kSigninUrl,
+ kSigninUrl,
+ -1, // no tab id.
+ signin_process.GetID(),
+ &error))
<< error;
}
#endif
« no previous file with comments | « chrome/browser/extensions/browser_permissions_policy_delegate.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698