content/browser/web_contents/web_contents_impl.h - Issue 321253003: Ensure show/hide are properly called on interstitial pages if present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 321253003: Ensure show/hide are properly called on interstitial pages if present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test compilation, add test case for the bug. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 266ed472c608cbe504d6dc042568dcbb10ac9a6f..7880d92e5f432bac0d56c722a3db6d1ec1dbe671 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -673,8 +673,8 @@ class CONTENT_EXPORT WebContentsImpl

void RemoveDestructionObserver(WebContentsImpl* web_contents);

// Traverses all the RenderFrameHosts in the FrameTree and creates a set

- // all the unique RenderWidgetHosts.

- std::set<RenderWidgetHostImpl*> GetRenderWidgetHostsInTree();

+ // all the unique RenderWidgetHostViews.

+ std::set<RenderWidgetHostView*> GetRenderWidgetHostViewsInTree();

// Callback function when showing JavaScript dialogs. Takes in a routing ID

// pair to identify the RenderFrameHost that opened the dialog, because it's

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »