Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 321253003: Ensure show/hide are properly called on interstitial pages if present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test compilation, add test case for the bug. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 1bcf3fc8a4e7919ff96c75f64111af868b5f2450..5193a7d798962f7b304f88e8f52075fcb18addb1 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -219,10 +219,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CrossSiteIframe) {
{
// There should be only one RenderWidgetHost when there are no
// cross-process iframes.
- std::set<RenderWidgetHostImpl*> widgets_set =
+ std::set<RenderWidgetHostView*> views_set =
static_cast<WebContentsImpl*>(shell()->web_contents())
- ->GetRenderWidgetHostsInTree();
- EXPECT_EQ(1U, widgets_set.size());
+ ->GetRenderWidgetHostViewsInTree();
+ EXPECT_EQ(1U, views_set.size());
}
// These must stay in scope with replace_host.
@@ -249,10 +249,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CrossSiteIframe) {
{
// There should be now two RenderWidgetHosts, one for each process
// rendering a frame.
- std::set<RenderWidgetHostImpl*> widgets_set =
+ std::set<RenderWidgetHostView*> views_set =
static_cast<WebContentsImpl*>(shell()->web_contents())
- ->GetRenderWidgetHostsInTree();
- EXPECT_EQ(2U, widgets_set.size());
+ ->GetRenderWidgetHostViewsInTree();
+ EXPECT_EQ(2U, views_set.size());
}
// Load another cross-site page into the same iframe.
@@ -279,10 +279,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CrossSiteIframe) {
child->current_frame_host()->GetProcess());
EXPECT_NE(rph, child->current_frame_host()->GetProcess());
{
- std::set<RenderWidgetHostImpl*> widgets_set =
+ std::set<RenderWidgetHostView*> views_set =
static_cast<WebContentsImpl*>(shell()->web_contents())
- ->GetRenderWidgetHostsInTree();
- EXPECT_EQ(2U, widgets_set.size());
+ ->GetRenderWidgetHostViewsInTree();
+ EXPECT_EQ(2U, views_set.size());
}
}
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698