Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 321253003: Ensure show/hide are properly called on interstitial pages if present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test compilation, add test case for the bug. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 666
667 // Creates and adds to the map a destruction observer watching |web_contents|. 667 // Creates and adds to the map a destruction observer watching |web_contents|.
668 // No-op if such an observer already exists. 668 // No-op if such an observer already exists.
669 void AddDestructionObserver(WebContentsImpl* web_contents); 669 void AddDestructionObserver(WebContentsImpl* web_contents);
670 670
671 // Deletes and removes from the map a destruction observer 671 // Deletes and removes from the map a destruction observer
672 // watching |web_contents|. No-op if there is no such observer. 672 // watching |web_contents|. No-op if there is no such observer.
673 void RemoveDestructionObserver(WebContentsImpl* web_contents); 673 void RemoveDestructionObserver(WebContentsImpl* web_contents);
674 674
675 // Traverses all the RenderFrameHosts in the FrameTree and creates a set 675 // Traverses all the RenderFrameHosts in the FrameTree and creates a set
676 // all the unique RenderWidgetHosts. 676 // all the unique RenderWidgetHostViews.
677 std::set<RenderWidgetHostImpl*> GetRenderWidgetHostsInTree(); 677 std::set<RenderWidgetHostView*> GetRenderWidgetHostViewsInTree();
678 678
679 // Callback function when showing JavaScript dialogs. Takes in a routing ID 679 // Callback function when showing JavaScript dialogs. Takes in a routing ID
680 // pair to identify the RenderFrameHost that opened the dialog, because it's 680 // pair to identify the RenderFrameHost that opened the dialog, because it's
681 // possible for the RenderFrameHost to be deleted by the time this is called. 681 // possible for the RenderFrameHost to be deleted by the time this is called.
682 void OnDialogClosed(int render_process_id, 682 void OnDialogClosed(int render_process_id,
683 int render_frame_id, 683 int render_frame_id,
684 IPC::Message* reply_msg, 684 IPC::Message* reply_msg,
685 bool dialog_was_suppressed, 685 bool dialog_was_suppressed,
686 bool success, 686 bool success,
687 const base::string16& user_input); 687 const base::string16& user_input);
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
1130 bool last_dialog_suppressed_; 1130 bool last_dialog_suppressed_;
1131 1131
1132 scoped_ptr<GeolocationDispatcherHost> geolocation_dispatcher_host_; 1132 scoped_ptr<GeolocationDispatcherHost> geolocation_dispatcher_host_;
1133 1133
1134 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 1134 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
1135 }; 1135 };
1136 1136
1137 } // namespace content 1137 } // namespace content
1138 1138
1139 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1139 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698