Issue 321123002: Make presubmit script happy again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321123002: Make presubmit script happy again. (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev, Paweł Hajdan Jr., tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Make presubmit script happy again. No clue why this seems to be an issue only for me, though... R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21735

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -20 lines)			Patch
M	include/v8-util.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	samples/process.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/base/build_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/mips/assembler-mips.h	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips/assembler-mips.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

Committed patchset #2 manually as r21735 (presubmit successful).

6 years, 6 months ago (2014-06-10 09:24:09 UTC) #3

tfarina

6 years, 6 months ago (2014-06-10 15:55:45 UTC) #4

Message was sent while issue was closed.

It wasn't only you. I got these warnings from presubmit too.