Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320683002: Extracted PrivetV1HTTPClient with Privet v1 specific operations. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Extracted PrivetV1HTTPClient with Privet v1 specific operations. BUG=372843 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275717

Patch Set 1 #

Patch Set 2 : Fri 06/06/2014 23:59:01.38 #

Patch Set 3 : Sat 06/07/2014 0:02:34.90 #

Patch Set 4 : Sat 06/07/2014 0:12:52.49 #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -157 lines) Patch
M chrome/browser/local_discovery/privet_http.h View 3 chunks +33 lines, -9 lines 0 comments Download
A chrome/browser/local_discovery/privet_http.cc View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_mac.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 12 chunks +53 lines, -44 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 9 chunks +82 lines, -59 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 3 4 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/privet_local_printer_lister.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_operations.h View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_operations.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-07 06:44:11 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-07 06:44:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/320683002/1
6 years, 6 months ago (2014-06-07 06:45:04 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-07 07:03:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/320683002/10002
6 years, 6 months ago (2014-06-07 07:04:02 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-07 07:13:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/320683002/40001
6 years, 6 months ago (2014-06-07 07:14:35 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 10:48:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 10:49:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/193161)
6 years, 6 months ago (2014-06-07 10:49:49 UTC) #10
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-07 22:32:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/320683002/60001
6 years, 6 months ago (2014-06-07 22:33:11 UTC) #12
commit-bot: I haz the power
Change committed as 275717
6 years, 6 months ago (2014-06-08 02:09:17 UTC) #13
Noam Samuel
lgtm Do you use a code autoformatter? There's a lot of touched files with just ...
6 years, 6 months ago (2014-06-09 17:41:52 UTC) #14
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-09 19:27:19 UTC) #15 
yes, but I am not sure why they got into CL



On Mon, Jun 9, 2014 at 10:41 AM, <noamsml@chromium.org> wrote:

> lgtm
>
> Do you use a code autoformatter? There's a lot of touched files with just
> formatting changes.
>
> https://codereview.chromium.org/320683002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698