chrome/browser/local_discovery/storage/privet_filesystem_operations.h - Issue 320683002: Extracted PrivetV1HTTPClient with Privet v1 specific operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/storage/privet_filesystem_operations.h

Issue 320683002: Extracted PrivetV1HTTPClient with Privet v1 specific operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privet_notifications.cc ('k') | chrome/browser/local_discovery/storage/privet_filesystem_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/storage/privet_filesystem_operations.h

diff --git a/chrome/browser/local_discovery/storage/privet_filesystem_operations.h b/chrome/browser/local_discovery/storage/privet_filesystem_operations.h

index a615c93aeccff2e1dec21ec4877f63cfb60eb214..6701db4592c2568b0b020401c3bdbc0bd2f036eb 100644

--- a/chrome/browser/local_discovery/storage/privet_filesystem_operations.h

+++ b/chrome/browser/local_discovery/storage/privet_filesystem_operations.h

@@ -75,9 +75,8 @@ class PrivetFileSystemAsyncOperationUtil {

// |http_client| is the client for the resolved service, or NULL if

// resolution failed. |path| is the canonical path within the privet

// service.

- virtual void PrivetFileSystemResolved(

- PrivetHTTPClient* http_client,

- const std::string& path) = 0;

+ virtual void PrivetFileSystemResolved(PrivetV1HTTPClient* http_client,

+ const std::string& path) = 0;

};

PrivetFileSystemAsyncOperationUtil(const base::FilePath& full_path,

@@ -101,7 +100,7 @@ class PrivetFileSystemAsyncOperationUtil {

scoped_ptr<PrivetDeviceResolver> privet_device_resolver_;

scoped_ptr<PrivetHTTPAsynchronousFactory> privet_async_factory_;

scoped_ptr<PrivetHTTPResolution> privet_http_resolution_;

- scoped_ptr<PrivetHTTPClient> privet_client_;

+ scoped_ptr<PrivetV1HTTPClient> privet_client_;

base::WeakPtrFactory<PrivetFileSystemAsyncOperationUtil> weak_factory_;

};

@@ -120,9 +119,8 @@ class PrivetFileSystemListOperation

virtual void Start() OVERRIDE;

- virtual void PrivetFileSystemResolved(

- PrivetHTTPClient* http_client,

- const std::string& path) OVERRIDE;

+ virtual void PrivetFileSystemResolved(PrivetV1HTTPClient* http_client,

+ const std::string& path) OVERRIDE;

private:

void OnStorageListResult(const base::DictionaryValue* value);

@@ -155,7 +153,7 @@ class PrivetFileSystemDetailsOperation

virtual void Start() OVERRIDE;

- virtual void PrivetFileSystemResolved(PrivetHTTPClient* http_client,

+ virtual void PrivetFileSystemResolved(PrivetV1HTTPClient* http_client,

const std::string& path) OVERRIDE;

private: