chrome/browser/local_discovery/storage/privet_filesystem_operations.cc - Issue 320683002: Extracted PrivetV1HTTPClient with Privet v1 specific operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

Issue 320683002: Extracted PrivetV1HTTPClient with Privet v1 specific operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/storage/privet_filesystem_operations.h ('k') | chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

diff --git a/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc b/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

index a7095ae3193b788ab7eea15b823cb79007999425..66f144779887bf78e617fe57a6ae79d104f88aea 100644

--- a/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

+++ b/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

@@ -87,8 +87,7 @@ void PrivetFileSystemAsyncOperationUtil::OnGotDeviceDescription(

}

privet_async_factory_ = PrivetHTTPAsynchronousFactory::CreateInstance(

- service_discovery_client_.get(),

- request_context_.get());

+ service_discovery_client_.get(), request_context_.get());

privet_http_resolution_ = privet_async_factory_->CreatePrivetHTTP(

parsed_path_.service_name,

device_description.address,

@@ -100,7 +99,7 @@ void PrivetFileSystemAsyncOperationUtil::OnGotDeviceDescription(

void PrivetFileSystemAsyncOperationUtil::OnGotPrivetHTTP(

scoped_ptr<PrivetHTTPClient> privet_http_client) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

- privet_client_ = privet_http_client.Pass();

+ privet_client_ = PrivetV1HTTPClient::CreateDefault(privet_http_client.Pass());

delegate_->PrivetFileSystemResolved(privet_client_.get(),

parsed_path_.path);

}

@@ -129,7 +128,7 @@ void PrivetFileSystemListOperation::Start() {

}

void PrivetFileSystemListOperation::PrivetFileSystemResolved(

- PrivetHTTPClient* http_client,

+ PrivetV1HTTPClient* http_client,

const std::string& path) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

if (!http_client) {

@@ -241,7 +240,7 @@ void PrivetFileSystemDetailsOperation::Start() {

}

void PrivetFileSystemDetailsOperation::PrivetFileSystemResolved(

- PrivetHTTPClient* http_client,

+ PrivetV1HTTPClient* http_client,

const std::string& path) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

if (!http_client) {