Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 320513002: Remove base::kInvalidPlatformFileValue from Chrome (Closed)

Created:
6 years, 6 months ago by rvargas (doing something else)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, rouslan+spellwatch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove base::kInvalidPlatformFileValue from Chrome BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275542

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -36 lines) Patch
M chrome/browser/extensions/api/serial/serial_io_handler.cc View 2 chunks +10 lines, -2 lines 1 comment Download
M chrome/browser/extensions/api/serial/serial_io_handler_posix.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_io_handler_win.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/translate/translate_helper.h View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rvargas (doing something else)
PTAL https://codereview.chromium.org/320513002/diff/20001/chrome/browser/extensions/api/serial/serial_io_handler.cc File chrome/browser/extensions/api/serial/serial_io_handler.cc (right): https://codereview.chromium.org/320513002/diff/20001/chrome/browser/extensions/api/serial/serial_io_handler.cc#newcode21 chrome/browser/extensions/api/serial/serial_io_handler.cc:21: : file_(kInvalidPlatformFileValue), There is already a bug filed ...
6 years, 6 months ago (2014-06-06 19:18:06 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-06 19:56:53 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-06 21:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/320513002/20001
6 years, 6 months ago (2014-06-06 21:29:19 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 22:16:54 UTC) #5
Message was sent while issue was closed.
Change committed as 275542

Powered by Google App Engine
This is Rietveld 408576698