Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h

Issue 320513002: Remove base::kInvalidPlatformFileValue from Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/serial/serial_io_handler.cc ('K') | « chrome/browser/extensions/api/serial/serial_io_handler_win.cc ('k') | chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
diff --git a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
index f51d22a03cf884464fb40a79073babd44a2a59ff..8b27830ae7d957c50487f64503cba5be4b498686 100644
--- a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
+++ b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
@@ -11,7 +11,6 @@
#include "base/memory/weak_ptr.h"
#include "base/move.h"
#include "base/observer_list.h"
-#include "base/platform_file.h"
#include "chrome/browser/spellchecker/spellcheck_dictionary.h"
#include "net/url_request/url_fetcher_delegate.h"
@@ -61,8 +60,7 @@ class SpellcheckHunspellDictionary
// Returns true if the dictionary is ready to use.
virtual bool IsReady() const;
- // TODO(rlp): Return by value.
- base::PlatformFile GetDictionaryFile() const;
+ const base::File& GetDictionaryFile() const;
const std::string& GetLanguage() const;
bool IsUsingPlatformChecker() const;
« chrome/browser/extensions/api/serial/serial_io_handler.cc ('K') | « chrome/browser/extensions/api/serial/serial_io_handler_win.cc ('k') | chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698