chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc - Issue 320513002: Remove base::kInvalidPlatformFileValue from Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

Issue 320513002: Remove base::kInvalidPlatformFileValue from Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

diff --git a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

index 8b6251473bba8180338acaddfca083b84b459eaa..23377036c27f5ea89276efcbe9b3f74f85ee4928 100644

--- a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

+++ b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

@@ -138,12 +138,11 @@ void SpellcheckHunspellDictionary::RetryDownloadDictionary(

}

bool SpellcheckHunspellDictionary::IsReady() const {

- return GetDictionaryFile() !=

- base::kInvalidPlatformFileValue || IsUsingPlatformChecker();

+ return GetDictionaryFile().IsValid() || IsUsingPlatformChecker();

}

-base::PlatformFile SpellcheckHunspellDictionary::GetDictionaryFile() const {

- return dictionary_file_.file.GetPlatformFile();

+const base::File& SpellcheckHunspellDictionary::GetDictionaryFile() const {

+ return dictionary_file_.file;

}

const std::string& SpellcheckHunspellDictionary::GetLanguage() const {