Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel. (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com, epoger

Base URL:
https://skia.googlesource.com/buildbot@master

Visibility:
Public.

Use GetRemoteMasterHash() function instead of reinveting the wheel. This function from git_utils can be used at least in two more places, chrome_canary_update.py and sync_skia_in_chrome.py, making the code more cleaner. BUG=None TEST=None R=borenet@google.com Committed: https://skia.googlesource.com/buildbot/+/51a525390efd8ca7c47d462d25838073e14d0fac

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	slave/skia_slave_scripts/chrome_canary_update.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download
	M	slave/skia_slave_scripts/utils/sync_skia_in_chrome.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

tfarina

Looks like the change https://skia.googlesource.com/buildbot/+/49a080701357dc50ec03f40ccd9a2c64873f68af stuck. PTAL.

6 years, 6 months ago (2014-06-06 02:20:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/320503003/1

6 years, 6 months ago (2014-06-06 23:25:33 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-06 23:25:38 UTC) #5

Message was sent while issue was closed.

Change committed as 51a525390efd8ca7c47d462d25838073e14d0fac