slave/skia_slave_scripts/utils/sync_skia_in_chrome.py - Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/utils/sync_skia_in_chrome.py

Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel. (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: slave/skia_slave_scripts/utils/sync_skia_in_chrome.py

diff --git a/slave/skia_slave_scripts/utils/sync_skia_in_chrome.py b/slave/skia_slave_scripts/utils/sync_skia_in_chrome.py

index 7e53dc1abe5547c2c96a220e330a0d4cc709f991..64464a8adce6d30022b10f7d14d02bfb7f83ca2b 100644

--- a/slave/skia_slave_scripts/utils/sync_skia_in_chrome.py

+++ b/slave/skia_slave_scripts/utils/sync_skia_in_chrome.py

@@ -11,6 +11,7 @@ from optparse import OptionParser

from git_utils import GIT

import gclient_utils

+import git_utils

import os

import re

import shell_utils

@@ -62,8 +63,7 @@ def Sync(skia_revision=None, chrome_revision=None, use_lkgr_skia=False,

"""

# Figure out what revision of Skia we should use.

if not skia_revision:

- output = shell_utils.run([GIT, 'ls-remote', SKIA_GIT_URL, '--verify',

- 'refs/heads/master'])

+ output = git_utils.GetRemoteMasterHash(SKIA_GIT_URL)

if output:

skia_revision = shlex.split(output)[0]

if not skia_revision:

« no previous file with comments | « slave/skia_slave_scripts/chrome_canary_update.py ('k') | no next file » | no next file with comments »