slave/skia_slave_scripts/chrome_canary_update.py - Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/chrome_canary_update.py

Issue 320503003: Use GetRemoteMasterHash() function instead of reinveting the wheel. (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: slave/skia_slave_scripts/chrome_canary_update.py

diff --git a/slave/skia_slave_scripts/chrome_canary_update.py b/slave/skia_slave_scripts/chrome_canary_update.py

index 08f0ed3ef39d6a81552c0bb3606593ed7268a48f..7cb37350a28ea0a47bb84d71e6672c853e5cc631 100644

--- a/slave/skia_slave_scripts/chrome_canary_update.py

+++ b/slave/skia_slave_scripts/chrome_canary_update.py

@@ -7,7 +7,7 @@

# build_step must be imported first, since it does some tweaking of PYTHONPATH.

from build_step import BuildStep

-from utils.git_utils import GIT

+from utils import git_utils

from utils import shell_utils

from utils import sync_skia_in_chrome

import shlex

@@ -27,9 +27,7 @@ class ChromeCanaryUpdate(BuildStep):

**kwargs)

def _Run(self):

- chrome_rev = shlex.split(shell_utils.run(

- [GIT, 'ls-remote', CHROMIUM_REPO,

- 'refs/heads/master']))[0]

+ chrome_rev = shlex.split(git_utils.GetRemoteMasterHash(CHROMIUM_REPO))[0]

override_skia_checkout = True

if 'AutoRoll' in self._builder_name:

« no previous file with comments | « no previous file | slave/skia_slave_scripts/utils/sync_skia_in_chrome.py » ('j') | no next file with comments »