Componentize URLFixerUpper.

Componentize URLFixerUpper.

This CL moves URLFixerUpper into a new url_fixer component to allow this code
to be shared by the iOS port. At the present time the component contains some
minor Chrome-specific logic. Specifically, it rewrites about:// to chrome://
and uses about:// version as the default about:// host. We decided not to
abstract this logic at this time, as the only embedders wishing to use this
component are ports of Chrome.  However, if there comes to be a non-Chrome
embedder that wishes to use this component, this behavior could easily be
generalized (e.g., by exposing the variables that are used for these purposes
in the header file to allow the embedder to customize them).

BUG=373229
R=jam@chromium.org
TBR=mmenke
NOTREECHECKS=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276672

[blundell, 2014-06-09 10:25:35]

jam: For review. Follows the approach we discussed.
rsleevi: FYI.

[jam, 2014-06-09 23:26:33]

lgtm with owners Set to brettw+pkasting

https://codereview.chromium.org/320253004/diff/100001/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/320253004/diff/100001/components/OWNERS#newco...
components/OWNERS:173: per-file url_fixer.gypi=wtc@chromium.org
here and in the other OWNERS file: this should be whoever worked on this code.
It looks like none of the users above have committed any changes to the code
other than a one-liner by agl. I realize you picked this as
chrome/common/net/OWNERS since the moved files were located there; but I think
that is because it was the most logical spot for it (i.e. also by this logic, we
shouldn't just copy over src/chrome/OWNERS).

Scanning
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/url_fixer_u...,
a rough owner list could be:
pkasting@chromium.org

The original author is brettw. So add these two as owners for now.

[blundell, 2014-06-10 12:35:17]

https://codereview.chromium.org/320253004/diff/100001/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/320253004/diff/100001/components/OWNERS#newco...
components/OWNERS:173: per-file url_fixer.gypi=wtc@chromium.org
On 2014/06/09 23:26:32, jam wrote:
> here and in the other OWNERS file: this should be whoever worked on this code.
> It looks like none of the users above have committed any changes to the code
> other than a one-liner by agl. I realize you picked this as
> chrome/common/net/OWNERS since the moved files were located there; but I think
> that is because it was the most logical spot for it (i.e. also by this logic,
we
> shouldn't just copy over src/chrome/OWNERS).
> 
> Scanning
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/url_fixer_u...,
> a rough owner list could be:
> mailto:pkasting@chromium.org
> 
> The original author is brettw. So add these two as owners for now.

Done.

[blundell, 2014-06-10 15:26:05]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-10 15:28:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/320253004/120001

[jam, 2014-06-10 21:13:23]

https://codereview.chromium.org/320253004/diff/140001/components/url_fixer/OW...
File components/url_fixer/OWNERS (right):

https://codereview.chromium.org/320253004/diff/140001/components/url_fixer/OW...
components/url_fixer/OWNERS:2: per-file url_fixer.gypi=pkasting@chromium.org
remove the per-file

[blundell, 2014-06-11 09:06:47]

https://codereview.chromium.org/320253004/diff/140001/components/url_fixer/OW...
File components/url_fixer/OWNERS (right):

https://codereview.chromium.org/320253004/diff/140001/components/url_fixer/OW...
components/url_fixer/OWNERS:2: per-file url_fixer.gypi=pkasting@chromium.org
Derp. Done :).

On 2014/06/10 21:13:23, jam wrote:
> remove the per-file

[blundell, 2014-06-11 09:07:26]

TBR=mmenke for //net

[blundell, 2014-06-11 09:07:31]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-11 09:10:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/320253004/160001

[blundell, 2014-06-11 13:37:07]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:38:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/320253004/180001

[commit-bot: I haz the power, 2014-06-11 19:52:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[blundell, 2014-06-11 19:56:42]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-11 20:00:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/320253004/200001

[commit-bot: I haz the power, 2014-06-11 21:24:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15594)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18733)

[commit-bot: I haz the power, 2014-06-11 21:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:28:21]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15655)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18791)

[blundell, 2014-06-12 05:17:21]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-12 05:20:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/320253004/200001

[commit-bot: I haz the power, 2014-06-12 12:47:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-12 12:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 12:57:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[blundell, 2014-06-12 14:29:18]

Committed patchset #7 manually as r276672 (presubmit successful).