Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 320253004: Componentize URLFixerUpper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win64 fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/collected_cookies_browsertest.cc ('k') | chrome/browser/google/google_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_tab_util.h" 5 #include "chrome/browser/extensions/extension_tab_util.h"
6 6
7 #include "apps/app_window.h" 7 #include "apps/app_window.h"
8 #include "apps/app_window_registry.h" 8 #include "apps/app_window_registry.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 10 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
11 #include "chrome/browser/extensions/chrome_extension_function.h" 11 #include "chrome/browser/extensions/chrome_extension_function.h"
12 #include "chrome/browser/extensions/tab_helper.h" 12 #include "chrome/browser/extensions/tab_helper.h"
13 #include "chrome/browser/extensions/window_controller.h" 13 #include "chrome/browser/extensions/window_controller.h"
14 #include "chrome/browser/extensions/window_controller_list.h" 14 #include "chrome/browser/extensions/window_controller_list.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/sessions/session_id.h" 16 #include "chrome/browser/sessions/session_id.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/browser_finder.h" 18 #include "chrome/browser/ui/browser_finder.h"
19 #include "chrome/browser/ui/browser_iterator.h" 19 #include "chrome/browser/ui/browser_iterator.h"
20 #include "chrome/browser/ui/browser_window.h" 20 #include "chrome/browser/ui/browser_window.h"
21 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h" 21 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
22 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" 22 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
23 #include "chrome/browser/ui/tabs/tab_strip_model.h" 23 #include "chrome/browser/ui/tabs/tab_strip_model.h"
24 #include "chrome/common/extensions/manifest_url_handler.h" 24 #include "chrome/common/extensions/manifest_url_handler.h"
25 #include "chrome/common/net/url_fixer_upper.h"
26 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
26 #include "components/url_fixer/url_fixer.h"
27 #include "content/public/browser/favicon_status.h" 27 #include "content/public/browser/favicon_status.h"
28 #include "content/public/browser/navigation_entry.h" 28 #include "content/public/browser/navigation_entry.h"
29 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
30 #include "extensions/common/constants.h" 30 #include "extensions/common/constants.h"
31 #include "extensions/common/error_utils.h" 31 #include "extensions/common/error_utils.h"
32 #include "extensions/common/extension.h" 32 #include "extensions/common/extension.h"
33 #include "extensions/common/manifest_constants.h" 33 #include "extensions/common/manifest_constants.h"
34 #include "extensions/common/manifest_handlers/incognito_info.h" 34 #include "extensions/common/manifest_handlers/incognito_info.h"
35 #include "extensions/common/permissions/api_permission.h" 35 #include "extensions/common/permissions/api_permission.h"
36 #include "extensions/common/permissions/permissions_data.h" 36 #include "extensions/common/permissions/permissions_data.h"
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 GURL url = GURL(url_string); 488 GURL url = GURL(url_string);
489 if (!url.is_valid()) 489 if (!url.is_valid())
490 url = extension->GetResourceURL(url_string); 490 url = extension->GetResourceURL(url_string);
491 491
492 return url; 492 return url;
493 } 493 }
494 494
495 bool ExtensionTabUtil::IsCrashURL(const GURL& url) { 495 bool ExtensionTabUtil::IsCrashURL(const GURL& url) {
496 // Check a fixed-up URL, to normalize the scheme and parse hosts correctly. 496 // Check a fixed-up URL, to normalize the scheme and parse hosts correctly.
497 GURL fixed_url = 497 GURL fixed_url =
498 URLFixerUpper::FixupURL(url.possibly_invalid_spec(), std::string()); 498 url_fixer::FixupURL(url.possibly_invalid_spec(), std::string());
499 return (fixed_url.SchemeIs(content::kChromeUIScheme) && 499 return (fixed_url.SchemeIs(content::kChromeUIScheme) &&
500 (fixed_url.host() == content::kChromeUIBrowserCrashHost || 500 (fixed_url.host() == content::kChromeUIBrowserCrashHost ||
501 fixed_url.host() == chrome::kChromeUICrashHost)); 501 fixed_url.host() == chrome::kChromeUICrashHost));
502 } 502 }
503 503
504 void ExtensionTabUtil::CreateTab(WebContents* web_contents, 504 void ExtensionTabUtil::CreateTab(WebContents* web_contents,
505 const std::string& extension_id, 505 const std::string& extension_id,
506 WindowOpenDisposition disposition, 506 WindowOpenDisposition disposition,
507 const gfx::Rect& initial_pos, 507 const gfx::Rect& initial_pos,
508 bool user_gesture) { 508 bool user_gesture) {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 content::PAGE_TRANSITION_LINK, 571 content::PAGE_TRANSITION_LINK,
572 false); 572 false);
573 browser->OpenURL(params); 573 browser->OpenURL(params);
574 browser->window()->Show(); 574 browser->window()->Show();
575 WebContents* web_contents = 575 WebContents* web_contents =
576 browser->tab_strip_model()->GetActiveWebContents(); 576 browser->tab_strip_model()->GetActiveWebContents();
577 web_contents->GetDelegate()->ActivateContents(web_contents); 577 web_contents->GetDelegate()->ActivateContents(web_contents);
578 } 578 }
579 579
580 } // namespace extensions 580 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/collected_cookies_browsertest.cc ('k') | chrome/browser/google/google_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698