Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 320253004: Componentize URLFixerUpper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win64 fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/history_url_provider.h" 5 #include "chrome/browser/autocomplete/history_url_provider.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/browser/history/history_service.h" 23 #include "chrome/browser/history/history_service.h"
24 #include "chrome/browser/history/history_service_factory.h" 24 #include "chrome/browser/history/history_service_factory.h"
25 #include "chrome/browser/history/history_types.h" 25 #include "chrome/browser/history/history_types.h"
26 #include "chrome/browser/history/in_memory_url_index_types.h" 26 #include "chrome/browser/history/in_memory_url_index_types.h"
27 #include "chrome/browser/history/scored_history_match.h" 27 #include "chrome/browser/history/scored_history_match.h"
28 #include "chrome/browser/omnibox/omnibox_field_trial.h" 28 #include "chrome/browser/omnibox/omnibox_field_trial.h"
29 #include "chrome/browser/profiles/profile.h" 29 #include "chrome/browser/profiles/profile.h"
30 #include "chrome/browser/search_engines/template_url_service.h" 30 #include "chrome/browser/search_engines/template_url_service.h"
31 #include "chrome/browser/search_engines/template_url_service_factory.h" 31 #include "chrome/browser/search_engines/template_url_service_factory.h"
32 #include "chrome/common/chrome_switches.h" 32 #include "chrome/common/chrome_switches.h"
33 #include "chrome/common/net/url_fixer_upper.h"
34 #include "chrome/common/pref_names.h" 33 #include "chrome/common/pref_names.h"
35 #include "chrome/common/url_constants.h" 34 #include "chrome/common/url_constants.h"
36 #include "components/bookmarks/browser/bookmark_utils.h" 35 #include "components/bookmarks/browser/bookmark_utils.h"
37 #include "components/metrics/proto/omnibox_input_type.pb.h" 36 #include "components/metrics/proto/omnibox_input_type.pb.h"
37 #include "components/url_fixer/url_fixer.h"
38 #include "net/base/net_util.h" 38 #include "net/base/net_util.h"
39 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 39 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
40 #include "url/gurl.h" 40 #include "url/gurl.h"
41 #include "url/url_parse.h" 41 #include "url/url_parse.h"
42 #include "url/url_util.h" 42 #include "url/url_util.h"
43 43
44 namespace { 44 namespace {
45 45
46 // Acts like the > operator for URLInfo classes. 46 // Acts like the > operator for URLInfo classes.
47 bool CompareHistoryMatch(const history::HistoryMatch& a, 47 bool CompareHistoryMatch(const history::HistoryMatch& a,
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 TemplateURL* default_search_provider = template_url_service ? 474 TemplateURL* default_search_provider = template_url_service ?
475 template_url_service->GetDefaultSearchProvider() : NULL; 475 template_url_service->GetDefaultSearchProvider() : NULL;
476 UIThreadSearchTermsData data(profile_); 476 UIThreadSearchTermsData data(profile_);
477 477
478 // Do some fixup on the user input before matching against it, so we provide 478 // Do some fixup on the user input before matching against it, so we provide
479 // good results for local file paths, input with spaces, etc. 479 // good results for local file paths, input with spaces, etc.
480 const FixupReturn fixup_return(FixupUserInput(input)); 480 const FixupReturn fixup_return(FixupUserInput(input));
481 if (!fixup_return.first) 481 if (!fixup_return.first)
482 return; 482 return;
483 url::Parsed parts; 483 url::Parsed parts;
484 URLFixerUpper::SegmentURL(fixup_return.second, &parts); 484 url_fixer::SegmentURL(fixup_return.second, &parts);
485 AutocompleteInput fixed_up_input(input); 485 AutocompleteInput fixed_up_input(input);
486 fixed_up_input.UpdateText(fixup_return.second, base::string16::npos, parts); 486 fixed_up_input.UpdateText(fixup_return.second, base::string16::npos, parts);
487 487
488 // Create the data structure for the autocomplete passes. We'll save this off 488 // Create the data structure for the autocomplete passes. We'll save this off
489 // onto the |params_| member for later deletion below if we need to run pass 489 // onto the |params_| member for later deletion below if we need to run pass
490 // 2. 490 // 2.
491 scoped_ptr<HistoryURLProviderParams> params( 491 scoped_ptr<HistoryURLProviderParams> params(
492 new HistoryURLProviderParams( 492 new HistoryURLProviderParams(
493 fixed_up_input, trim_http, 493 fixed_up_input, trim_http,
494 profile_->GetPrefs()->GetString(prefs::kAcceptLanguages), 494 profile_->GetPrefs()->GetString(prefs::kAcceptLanguages),
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1155 AutocompleteMatch::ClassifyLocationInString(base::string16::npos, 0, 1155 AutocompleteMatch::ClassifyLocationInString(base::string16::npos, 0,
1156 match.contents.length(), ACMatchClassification::URL, 1156 match.contents.length(), ACMatchClassification::URL,
1157 &match.contents_class); 1157 &match.contents_class);
1158 } 1158 }
1159 match.description = info.title(); 1159 match.description = info.title();
1160 match.description_class = 1160 match.description_class =
1161 ClassifyDescription(params.input.text(), match.description); 1161 ClassifyDescription(params.input.text(), match.description);
1162 RecordAdditionalInfoFromUrlRow(info, &match); 1162 RecordAdditionalInfoFromUrlRow(info, &match);
1163 return match; 1163 return match;
1164 } 1164 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.cc ('k') | chrome/browser/autocomplete/history_url_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698